Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

pwasm with FromSenderSaltAndCodeHash scheme contract creation #9139

Closed
sorpaas opened this issue Jul 17, 2018 · 0 comments
Closed

pwasm with FromSenderSaltAndCodeHash scheme contract creation #9139

sorpaas opened this issue Jul 17, 2018 · 0 comments
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon.
Milestone

Comments

@sorpaas
Copy link
Collaborator

sorpaas commented Jul 17, 2018

rel #9140

Currently, in parity-ethereum's wasm engine, we use FromSenderAndCodeHash scheme for create extern runtime. This seems to be from the old EIP-86 CREATE_P2SH opcode. The issue with this, as pointed out in EIP-86, is that one contract cannot create multiple "sub"-contracts with the same init code.

Would we consider to add a new create2 extern runtime for pwasm to support FromSenderSaltAndCodeHash scheme (i.e. when generating contract address, keccak sender, a 32 byte "salt", and code hash, instead of only keccak sender and code hash)?

@sorpaas sorpaas added P5-sometimesoon 🌲 Issue is worth doing soon. F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. labels Jul 17, 2018
@5chdn 5chdn added this to the 2.1 milestone Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
F3-annoyance 💩 The client behaves within expectations, however this “expected behaviour” itself is at issue. M4-core ⛓ Core client code / Rust. P5-sometimesoon 🌲 Issue is worth doing soon.
Projects
None yet
Development

No branches or pull requests

2 participants