Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

[beta] Backports #8916

Merged
merged 16 commits into from
Jun 19, 2018
Merged

[beta] Backports #8916

merged 16 commits into from
Jun 19, 2018

Commits on Jun 18, 2018

  1. duration_ns: u64 -> duration: Duration (#8457) 

    * duration_ns: u64 -> duration: Duration

* format on millis {:.2} -> {}
    @niklasad1 @andresilva
    niklasad1 authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    f99a47a View commit details
    Browse the repository at this point in the history

  2. Keep all enacted blocks notify in order (#8524) 

    * Keep all enacted blocks notify in order

* Collect is unnecessary

* Update ChainNotify to use ChainRouteType

* Fix all ethcore fn defs

* Wrap the type within ChainRoute

* Fix private-tx and sync api

* Fix secret_store API

* Fix updater API

* Fix rpc api

* Fix informant api

* Eagerly cache enacted/retracted and remove contain_enacted/retracted

* Fix indent

* tests: should use full expr form for struct constructor

* Use into_enacted_retracted to further avoid copy

* typo: not a function

* rpc/tests: ChainRoute -> ChainRoute::new
    @sorpaas @andresilva
    sorpaas authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    3ba4fe2 View commit details
    Browse the repository at this point in the history

  3. Handle removed logs in filter changes and add geth compatibility field ( 

    #8796)

* Add removed geth compatibility field in log

* Fix mocked tests

* Add field block hash in PollFilter

* Store last block hash info for log filters

* Implement canon route

* Use canon logs for fetching reorg logs

Light client removed logs fetching is disabled. It looks expensive.

* Make sure removed flag is set

* Address grumbles
    @sorpaas @andresilva
    sorpaas authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    75cff42 View commit details
    Browse the repository at this point in the history

  4. Fixed AuthorityRound deadlock on shutdown, closes #8088 (#8803)

    @debris @andresilva
    debris authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    a5ecc66 View commit details
    Browse the repository at this point in the history

  5. CI: Fix docker tags (#8822) 

    * scripts: enable docker builds for beta and stable

* scripts: docker latest should be beta not master

* scripts: docker latest is master
    @5chdn @andresilva
    5chdn authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    771c7d9 View commit details
    Browse the repository at this point in the history

  6. ethcore: fix ancient block error msg handling (#8832)

    @andresilva
    andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    9475dc1 View commit details
    Browse the repository at this point in the history

  7. Disable parallel verification and skip verifiying already imported tx… 

    …s. (#8834)

* Reject transactions that are already in pool without verifying them.

* Avoid verifying already imported transactions.
    @tomusdrw @andresilva
    tomusdrw authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    e5f2042 View commit details
    Browse the repository at this point in the history

  8. Fix concurrent access to signer queue (#8854) 

    * Fix concurrent access to signer queue

* Put request back to the queue if confirmation failed

* typo: fix docs and rename functions to be more specific

`request_notify` does not need to be public, and it's renamed to `notify_result`.
`notify` is renamed to `notify_message`.

* Change trace info "Transaction" -> "Request"
    @sorpaas @andresilva
    sorpaas authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    d3fb909 View commit details
    Browse the repository at this point in the history

  9. Don't allocate in expect_valid_rlp unless necessary (#8867) 

    * don't allocate via format! in case there's no error

* fix test?
    @ordian @andresilva
    ordian authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    d8d2792 View commit details
    Browse the repository at this point in the history

  10. fixed ipc leak, closes #8774 (#8876)

    @debris @andresilva
    debris authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    f616d72 View commit details
    Browse the repository at this point in the history

  11. Add new ovh bootnodes and fix port for foundation bootnode 3.2 (#8886) 

    * Add new ovh bootnodes and fix port for foundation bootnode 3.2

* Remove old bootnodes.

* Remove duplicate 1118980bf48b0a3640bdba04e0fe78b1add18e1cd99bf22d53daac1fd9972ad650df52176e7c7d89d1114cfef2bc23a2959aa54998a46afcf7d91809f0855082
    @ddorgan @andresilva
    ddorgan authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    27670a6 View commit details
    Browse the repository at this point in the history

  12. Block 0 is valid in queries (#8891) 

    Early exit for block nr 0 leads to spurious error about pruning: `…your node is running with state pruning…`.

Fixes #7547, #8762
    @dvdplm @andresilva
    dvdplm authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    36f8ca0 View commit details
    Browse the repository at this point in the history

  13. Add ETC Cooperative-run load balanced parity node (#8892)

    @pyskell @andresilva
    pyskell authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    66580f8 View commit details
    Browse the repository at this point in the history

  14. Minor fix in chain supplier and light provider (#8906) 

    * fix chain supplier increment

* fix light provider block_headers
    @andresilva
    andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    e0b7da9 View commit details
    Browse the repository at this point in the history

  15. Check whether we need resealing in miner and unwrap has_account in ac… 

    …count_provider (#8853)

* Remove unused Result wrap in has_account

* Check whether we need to reseal for external transactions

* Fix reference to has_account interface

* typo: missing )

* Refactor duplicates to prepare_and_update_sealing

* Fix build
    @sorpaas @andresilva
    sorpaas authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    8a31321 View commit details
    Browse the repository at this point in the history

  16. Allow disabling local-by-default for transactions with new config ent… 

    …ry (#8882)

* Add tx_queue_allow_unknown_local config option

- Previous commit messages:

dispatcher checks if we have the sender account

Add `tx_queue_allow_unknown_local` to MinerOptions

Add `tx_queue_allow_unknown_local` to config

fix order in MinerOptions to match Configuration

add cli flag for tx_queue_allow_unknown_local

Update refs to `tx_queue_allow_unknown_local`

Add tx_queue_allow_unknown_local to config test

revert changes to dispatcher

Move tx_queue_allow_unknown_local to `import_own_transaction`

Fix var name

if statement should return the values

derp de derp derp derp semicolons

Reset dispatch file to how it was before

fix compile issues + change from FLAG to ARG

add test and use `into`

import MinerOptions, clone the secret

Fix tests?

Compiler/linter issues fixed

Fix linter msg - case of constants

IT LIVES

refactor to omit yucky explict return

update comments

Fix based on diff AccountProvider.has_account method

* Refactor flag name + don't change import_own_tx behaviour

fix arg name

Note: force commit to try and get gitlab tests working again 😠

* Add fn to TestMinerService

* Avoid race condition from trusted sources

- refactor the miner tests a bit to cut down on code reuse
- add `trusted` param to dispatch_transaction and import_claimed_local_transaction

Add param to `import_claimed_local_transaction`

Fix fn sig in tests
    @XertroV @andresilva
    XertroV authored and andresilva committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    228a2ea View commit details
    Browse the repository at this point in the history