Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CKEditor4 dependency from oe_media_embed module #233

Closed
vengador opened this issue Jan 10, 2024 · 1 comment
Closed

Remove CKEditor4 dependency from oe_media_embed module #233

vengador opened this issue Jan 10, 2024 · 1 comment

Comments

@vengador
Copy link
Contributor

As I commented in openeuropa/oe_oembed#50, due to CKEditor 5 support added to 0.9.0 version of oe_oembed module, there is no reason to keep CKEditor4 dependency because oe_oembed should support both versions (4 and 5) so I think we should remove that dependency here too.
@vengador vengador mentioned this issue Jan 10, 2024
Closed
@nagyad
Copy link
Member

nagyad commented Feb 7, 2024

Fixed.

@nagyad nagyad closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vengador @nagyad