Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Helm Chart for FaaS #10

Closed
errm opened this issue Aug 7, 2017 · 16 comments
Closed

Create a Helm Chart for FaaS #10

errm opened this issue Aug 7, 2017 · 16 comments

Comments

@errm
Copy link

errm commented Aug 7, 2017

A helm chart would make deploying FasS to Kubernetes much simpler, and it is quickly becoming the standard way to try out third party solutions on Kubernetes...

Once FaaS on kubernetes is somewhat stable we can then submit our chart to the official repo ... https://github.com/kubernetes/charts

I am happy to work on this unless someone else wants to give it a go...

@alexellis
Copy link
Member

Please go ahead @errm this sounds like a great idea. What repo would it live in?

@errm
Copy link
Author

errm commented Aug 7, 2017

I guess here for now ...

@alexellis
Copy link
Member

No problems. Does this also need #3 to be done?

@alexellis
Copy link
Member

Hey Ed have you had a go at this?

@svperfecta
Copy link

We're actually doing this now. We might be able to get a pull request in for it.

cc: @cforbes

@weikinhuang
Copy link
Contributor

I opened a PR for this, can't use dynamic named services because a few of the containers have hard coded values.

@alexellis
Copy link
Member

alexellis commented Sep 22, 2017

Thanks for starting this @weikinhuang

@genexp @weikinhuang @errm what do we need to wrap this up? Does it test out OK?

@weikinhuang the hard-coded values are kept in the main FaaS repo here - https://github.com/alexellis/faas/tree/master/prometheus

^ that's where we need to update and then I have to re-push the builds from Docker Hub.

Also - does this create a permanent dependency on helm?

@weikinhuang
Copy link
Contributor

I'll leave it to everyone else on deciding if helm is going to be the preferred deployment method (which lets us get rid of having hard coded values in the main repo, and lets us use configmap mounted volumes). We can also keep the regular yaml files and update them with the configmaps that are found in the helm charts
(thereby removing them from the main repo as well and not having to build custom copies of prometheus and alertmanager).

@alexellis
Copy link
Member

alexellis commented Sep 22, 2017

I'd say we need to support both for now.. so let's go with the pain. It's easy to remove the hard-coded "vanilla" config in the future if helm is supported on all platforms we need.

Custom copies will be needed for Docker Swarm.

@weikinhuang
Copy link
Contributor

I can create vanilla configmaps for this, would prevent you from having to build 2 images, and we can use stock docker hub images.

@alexellis
Copy link
Member

Derek add label: hacktoberfest

@gardlt
Copy link

gardlt commented Oct 1, 2017

I would be very interested in a openfaas helm chart since i am currently using this for all my deployments. Let me know how I can help.

@alexellis
Copy link
Member

alexellis commented Oct 2, 2017

Thanks to @weikinhuang for leading this. We still have a few things to do including helm lint:

https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements

@genexp, @errm, @gardlt, @e-beach if you can get involved with testing that would be great. I've compiled RBAC instructions here:

https://github.com/openfaas/faas-netes/blob/master/HELM.md

Once we're happy, how do we go about submitting this to the upstream Helm chart repo?

@gardlt
Copy link

gardlt commented Oct 2, 2017

i cant seem to package the helm chart:
helm packaget ./helm

Error: directory name (helm) and Chart.yaml name (openfaas) must match

@alexellis
Copy link
Member

You can use the instructions in the link above for testing.

That error is the result of linting, do a mv helm openfaas and it should sort it.

@alexellis
Copy link
Member

Let's find out how to get this chart released and merged in kubernetes/charts

cc/ Captain @Spiddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants