Migrate CRDs to v1 namespace

[alexellis]

Migrate CRDs to v1 namespace

Expected Behaviour

helm lint should pass without failing a CI build, however with the latest version of helm3, this causes an unrecoverable error in CI.

Steps to reproduce the issue

• Clone this repo
• Download latest helm 3 arkade get helm --version v3.4.0
• Run helm lint

See failing error.

==> Linting .
[ERROR] templates/profile-crd.yaml: the kind "apiextensions.k8s.io/v1beta1 CustomResourceDefinition" is deprecated in favor of "apiextensions.k8s.io/v1 CustomResourceDefinition"
Error: 1 chart(s) linted, 1 chart(s) failed

Possible solution

• Update the tooling that generates the CRD YAML
• Update the chart's templates with generated YAML
• Re-test and check for breakages
• Note down any backwards compatibility changes. What is the new min-version of K8s after the migration?

Here is an example PR from the Contour project projectcontour/contour#2678

[alexellis]

This will also apply to - https://github.com/openfaas/ingress-operator and https://github.com/inlets/inlets-operator

[alexellis]

@LucasRoesler please could you take a look?

[LucasRoesler]

@alexellis i am also getting the following lint errors

[ERROR] templates/controller-rbac.yaml: the kind "rbac.authorization.k8s.io/v1beta1 Role" is deprecated in favor of "rbac.authorization.k8s.io/v1 Role"
[ERROR] templates/controller-rbac.yaml: the kind "rbac.authorization.k8s.io/v1beta1 RoleBinding" is deprecated in favor of "rbac.authorization.k8s.io/v1 RoleBinding"
[ERROR] templates/controller-rbac.yaml: the kind "rbac.authorization.k8s.io/v1beta1 Role" is deprecated in favor of "rbac.authorization.k8s.io/v1 Role"
[ERROR] templates/controller-rbac.yaml: the kind "rbac.authorization.k8s.io/v1beta1 RoleBinding" is deprecated in favor of "rbac.authorization.k8s.io/v1 RoleBinding"

[LucasRoesler]

Doing a little bit of research

• k8s 1.16 introduced depreaction for apiextensions.k8s.io/v1beta1 in favor of apiextensions.k8s.io/v1, removal in 1.19
• k8s 1.17 introduced deprecation for rbac.authorization.k8s.io/v1beta1 and rbac.authorization.k8s.io/v1beta2 in favor of rbac.authorization.k8s.io/v1, removal in 1.20

If we upgrade the CRD api group, the minimum version become 1.16, while updating the RBAC group bumps the minium verison to 1.17

Current versions in the major cloud providers:

• GKE 1.16, 1.17, 1.18
• EKS: 1.14, 1.15, 1.16, 1.17, 1.18
• AKS: 1.16, 1.17, 1.18, 1.19
• Digital Ocean: 1.17, 1.18, 1.19

[LucasRoesler]

Apparently the operator RBAC was already upgraded

faas-netes/chart/openfaas/templates/operator-rbac.yaml

Line 17 in e88c54c

apiVersion: rbac.authorization.k8s.io/v1