Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add commander testing infrastucture #357

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

sergiught
Copy link
Contributor

@sergiught sergiught commented Jun 27, 2024

Description

This PR adds support for testing the CLI commands through the use of the commander tool, and thus having complete E2E tests. Furthermore we are able to also calculate coverage support through the latest Go tool chain improvements.

In order to run the tests, we are using a locally running openfga server that gets spinned up through docker.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@sergiught sergiught marked this pull request as ready for review June 27, 2024 10:45
@sergiught sergiught requested a review from a team as a code owner June 27, 2024 10:45
@Siddhant-K-code
Copy link
Contributor

This is great ❤️

& TIL about this

Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for kicking us off on this @sergiught ❤️

@ewanharris ewanharris added this pull request to the merge queue Jun 28, 2024
Merged via the queue into main with commit 6a4f372 Jun 28, 2024
17 checks passed
@ewanharris ewanharris deleted the tests/commander branch June 28, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants