Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): allow specifying api url with port and path #57

Merged
merged 2 commits into from
Dec 6, 2023
Merged

feat(config): allow specifying api url with port and path #57

merged 2 commits into from
Dec 6, 2023

Conversation

rhamzeh
Copy link
Member

@rhamzeh rhamzeh commented Nov 30, 2023

Description

introduce ApiUrl and allow specifying port and path, and deprecate ApiScheme, ApiHost

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@rhamzeh rhamzeh force-pushed the feat/support-specifying-api-port-path branch 4 times, most recently from 2b492c8 to 9eeaf31 Compare November 30, 2023 17:19
@rhamzeh
fix: use latest api interfaces
aae9db4
@rhamzeh
feat(config): allow specifying api url with port and path
cdd7206 
deprecate ApiScheme, ApiHost and replace them with ApiUrl

close #56
@rhamzeh rhamzeh force-pushed the feat/support-specifying-api-port-path branch from 9eeaf31 to cdd7206 Compare December 6, 2023 15:35
@rhamzeh rhamzeh changed the base branch from main to fix/use-latest-api December 6, 2023 15:36
@rhamzeh rhamzeh marked this pull request as ready for review December 6, 2023 15:36
@rhamzeh rhamzeh requested a review from a team as a code owner December 6, 2023 15:36
adriantam
adriantam previously approved these changes Dec 6, 2023
View reviewed changes
Base automatically changed from fix/use-latest-api to main December 6, 2023 15:44
@rhamzeh rhamzeh dismissed adriantam’s stale review December 6, 2023 15:44

The base branch was changed.

@rhamzeh rhamzeh enabled auto-merge December 6, 2023 15:45
@rhamzeh rhamzeh added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 3c51f82 Dec 6, 2023
10 checks passed
@rhamzeh rhamzeh deleted the feat/support-specifying-api-port-path branch December 6, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriantam adriantam adriantam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot make calls to OpenFGA when exposed under path
2 participants
@rhamzeh @adriantam