Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove canonical import path from oauth2 packages #64

Merged
merged 1 commit into from
Dec 19, 2023
Merged

fix: remove canonical import path from oauth2 packages #64

merged 1 commit into from
Dec 19, 2023

Conversation

bketelsen
Copy link
Contributor

@bketelsen bketelsen commented Dec 19, 2023 •
edited by rhamzeh
Loading

remove canonical imports from oauth2 packages

Description

References

closes #63

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@bketelsen bketelsen requested a review from a team as a code owner December 19, 2023 19:03
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 19, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: bketelsen / name: Brian Ketelsen (4ac28b0)

@bketelsen bketelsen mentioned this pull request Dec 19, 2023
Closed
@rhamzeh
Copy link
Member

rhamzeh commented Dec 19, 2023

Thanks @bketelsen - May I ask you to sign the CNCF EasyCLA above so that we can merge?

@bketelsen bketelsen mentioned this pull request Dec 19, 2023
Closed
@bketelsen
Copy link
Contributor Author

Thanks @bketelsen - May I ask you to sign the CNCF EasyCLA above so that we can merge?

Done!

@rhamzeh rhamzeh added this pull request to the merge queue Dec 19, 2023
@rhamzeh
Copy link
Member

rhamzeh commented Dec 19, 2023

Thanks for the help! Will issue a new release in a few

Merged via the queue into openfga:main with commit 7e4ec4e Dec 19, 2023
5 checks passed
@bketelsen bketelsen deleted the canonical-imports branch December 19, 2023 19:25
@bketelsen
Copy link
Contributor Author

thanks for the super quick merge!

@rhamzeh rhamzeh mentioned this pull request Dec 19, 2023
Merged
4 tasks
rhamzeh pushed a commit to openfga/sdk-generator that referenced this pull request Dec 20, 2023
@bketelsen @rhamzeh
fix(go-sdk): remove canonical import path from oauth2 packages
676059d 
backport of openfga/go-sdk#64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oauth2 package retains canonical import path from original code
2 participants
@bketelsen @rhamzeh