Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postgresql subchart #112

Merged
merged 4 commits into from
Mar 7, 2024
Merged

fix: postgresql subchart #112

merged 4 commits into from
Mar 7, 2024

Conversation

jon-whit
Copy link
Collaborator

@jon-whit jon-whit commented Mar 7, 2024

Description

In #89 I broke the Helm chart for those users who want to quickly deploy Postgres alongside the OpenFGA service. This fixes that. I verified the commands in the README work.

References

#89

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jon-whit jon-whit requested a review from a team as a code owner March 7, 2024 23:06
@jon-whit jon-whit changed the title Fix postgresql subchart fix: postgresql subchart Mar 7, 2024
rhamzeh
rhamzeh previously approved these changes Mar 7, 2024
willvedd
willvedd previously approved these changes Mar 7, 2024
@jon-whit jon-whit dismissed stale reviews from willvedd and rhamzeh via 232b03f March 7, 2024 23:14
@jon-whit jon-whit enabled auto-merge (squash) March 7, 2024 23:18
@jon-whit jon-whit merged commit 7f6c0c7 into main Mar 7, 2024
4 checks passed
@jon-whit jon-whit deleted the fix-postgresql-subchart branch March 7, 2024 23:18
@evankanderson
Copy link

Hi, this seems to have renamed the postgres key to postgresql on a minor version update. This seems like a breaking change. I realize that the chart is at 0.1.39, so that could be expected, but I wanted to let you know that we're actually using this to deploy OpenFGA.

@evankanderson
Copy link

evankanderson commented Mar 7, 2024

We can change the key, but our ArgoCD deployment is currently in state Error with the following complaint:

Manifest generation error (cached):

`helm template . --name-template openfga --namespace openfga --kube-version 1.27 --values /tmp/3db5fc69-a673-4c62-b897-d09920b9b4c0 <api versions removed> --include-crds` failed exit status 1: Error: values don't meet the specifications of the schema(s) in the following chart(s): openfga: - (root): Additional property postgres is not allowed

Let us know whether we should switch to the new key or if the rename is going to be rolled back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants