Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: strip keys on CRUD operations #165

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: strip keys on CRUD operations #165

merged 2 commits into from
Mar 5, 2024

Conversation

alexgarel
Copy link
Member

fixes: #156 (trailing spaces)

@alexgarel alexgarel requested a review from a team as a code owner March 4, 2024 17:29
@alexgarel alexgarel requested a review from CharlesNepote March 4, 2024 18:04
CharlesNepote
CharlesNepote approved these changes Mar 5, 2024
View reviewed changes
Copy link
Member

@CharlesNepote CharlesNepote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine. I have well understood your code except the tests with those (for me) strange python code asynf def, async with, etc. I don't need to understand more and trust you.

@alexgarel alexgarel merged commit c0ee55b into main Mar 5, 2024
7 of 8 checks passed
@alexgarel alexgarel deleted the fix-strip-keys branch March 5, 2024 17:45
@github-actions github-actions bot mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesNepote CharlesNepote CharlesNepote approved these changes

Assignees

@alexgarel alexgarel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trailing spaces
2 participants
@alexgarel @CharlesNepote