Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location: Store the OSM POI version (for future update) #388

Closed
3 of 4 tasks
raphodn opened this issue Aug 20, 2024 · 0 comments · Fixed by #591 or #592
Closed
3 of 4 tasks

Location: Store the OSM POI version (for future update) #388

raphodn opened this issue Aug 20, 2024 · 0 comments · Fixed by #591 or #592

Comments

@raphodn
Copy link
Member

raphodn commented Aug 20, 2024

Story

When a new price location is provided, we only fetch basic POI data from OSM. But this POI can be updated in the future, or even deleted. We need to have a mechanism to update these POI, or at least know which version we have in OP.

Slack thread : https://openfoodfacts.slack.com/archives/C02Q6KM7F/p1724084895885059

Use cases

  • a shop closes and the OSM POI is deleted. We want to keep its prices and location info, but maybe display a closed label ?
  • a shop closes, and another reopens in replacement. the OSM POI is updated. These 2 locations will have the same OSM id+type, but we need to differenciate them (if Aldi replaces Franprix, prices for Franprix shouldn't be move to Aldi).

Todo

  • new Location.osm_version field
  • fetch data from OSM API
  • script to init data
  • how to update the data if it changes in OSM ?? (another issue to create)
@raphodn raphodn changed the title Store the location OSM version Store the location OSM POI version (for future update) Aug 20, 2024
@raphodn raphodn changed the title Store the location OSM POI version (for future update) Location: Store the OSM POI version (for future update) Sep 26, 2024
@raphodn raphodn moved this from Ready to In progress in 💸 Open Prices Dec 3, 2024
@raphodn raphodn linked a pull request Dec 3, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In progress to Done in 💸 Open Prices Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment