feat: new "Barcodes" parameter; deprecated configurations #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `Barcodes.dart`: "Barcodes" search API parameter. * `BoolMapParameter.dart`: Abstract map of `bool` as `Parameter`. Impacted files: * `AllergensParameter.dart`: refactored as `BoolMapParameter<AllergensTag>` * `api_getToBeCompletedProducts_test.dart`: minor refactoring around a deprecated class * `api_matchedProductV2_test.dart`: minor refactoring around a deprecated class * `api_searchProducts_test.dart`: fixed test duration; refactoring * `openfoodfacts.dart`: minor refactoring around a deprecated class * `ProductListQueryConfiguration.dart`: deprecated * `StatesTagsParameter.dart`: refactored as `BoolMapParameter<State>` * `ToBeCompletedConfiguration.dart`: deprecated
M123-dev
approved these changes
Aug 4, 2022
lib/model/parameter/Barcodes.dart
Outdated
| import 'package:openfoodfacts/interface/Parameter.dart'; | ||
|
|
||
| /// "Barcodes" search API parameter. | ||
| class Barcodes extends Parameter { |
There was a problem hiding this comment.
Thats a bit generic, what about BarcodeParameter
There was a problem hiding this comment.
@M123-dev Good point. "Filter" would even be better, but the rest is rather named "Parameter".
Renamed.
Impacted files: * `BarcodeParameter.dart` * `api_matchedProductV2_test.dart` * `api_searchProducts_test.dart` * `openfoodfacts.dart`
Impacted file: * `api_getProduct_test.dart`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New files:
Barcodes.dart: "Barcodes" search API parameter.BoolMapParameter.dart: Abstract map ofboolasParameter.Impacted files:
AllergensParameter.dart: refactored asBoolMapParameter<AllergensTag>api_getToBeCompletedProducts_test.dart: minor refactoring around a deprecated classapi_matchedProductV2_test.dart: minor refactoring around a deprecated classapi_searchProducts_test.dart: fixed test duration; refactoringopenfoodfacts.dart: minor refactoring around a deprecated classProductListQueryConfiguration.dart: deprecatedStatesTagsParameter.dart: refactored asBoolMapParameter<State>ToBeCompletedConfiguration.dart: deprecatedWhat
Barcodessearch parameterToBeCompletedConfigurationandProductListQueryConfigurationin favor ofProductSearchQueryConfigurationwith adapted parameters.AllergensParameterandStatesTagsParameteraround the newBoolMapParameter