Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 648 - new method "Nutriments.isEmpty" #649

Merged
merged 1 commit into from
Dec 25, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • api_getProduct_test.dart: added tests around new method Nutriments.isEmpty
  • Nutriments.dart: new method isEmpty; added comments

What

Fixes bug(s)

Impacted files:
* `api_getProduct_test.dart`: added tests around new method `Nutriments.isEmpty`
* `Nutriments.dart`: new method `isEmpty`; added comments
@codecov-commenter
Copy link

Codecov Report

Merging #649 (ca9c516) into master (44dfd2d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #649      +/-   ##
==========================================
+ Coverage   68.21%   68.26%   +0.05%     
==========================================
  Files         197      197              
  Lines        7855     7871      +16     
==========================================
+ Hits         5358     5373      +15     
- Misses       2497     2498       +1     
Impacted Files Coverage Δ
lib/model/Nutriments.dart 3.25% <100.00%> (+0.33%) ⬆️
test/api_getProduct_test.dart 92.91% <100.00%> (+0.10%) ⬆️
test/api_searchProducts_test.dart 98.37% <0.00%> (-0.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That definitely helpful, thanks @monsieurtanuki

@monsieurtanuki monsieurtanuki merged commit d04e9eb into openfoodfacts:master Dec 25, 2022
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev for your review!
On my side nothing pending, so feel free to release 1.30.0 if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New "isEmpty" method for Nutriments
3 participants