-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevention - On the fly quality checks in the product edit form (javascript) #1905
Comments
I think it's easy to add to my power user extension. Thus we can test it before launching it. I can code it with functions so that it will be easy to integrate in Product Opener later. |
@CharlesNepote any news? Can I start working on this? |
@VaiTon adding too much controls/warnings can be risky: some people could stop without saving their work. It's the kind of work that we need to test in real conditions, during some weeks, before it gets ready for everyone.
Maybe, if it's possible, these controls could be shown after saving, on the confirmation screen. |
The checks proposed by @teolemon seem very good to me. We don't have to prevent users from saving (especially if it is something that they did not change, but are just editing a product with bad values), but we should at the very least display a warning. |
hey @yuktea @stephanegigandet |
done, @jnsereko. |
created a PR #8258 |
What
Create on the fly quality check for the web
Part of
The text was updated successfully, but these errors were encountered: