Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevention - On the fly quality checks in the product edit form (javascript) #1905

Closed
2 tasks
Tracked by #10272
teolemon opened this issue Jun 9, 2019 · 7 comments · Fixed by #8258
Closed
2 tasks
Tracked by #10272

Prevention - On the fly quality checks in the product edit form (javascript) #1905

teolemon opened this issue Jun 9, 2019 · 7 comments · Fixed by #8258
Assignees
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality ✨ Feature Features or enhancements to Open Food Facts server Fixable via Userscript This issue can be fixed using the Power User Script. Hacktoberfest help wanted JavaScript 🧽 on-the-fly quality checks Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org Perl Related to the Perl code of the ProductOpener server

Comments

@teolemon
Copy link
Member

teolemon commented Jun 9, 2019

What

Create on the fly quality check for the web

  • Saturated fat > Total fat
  • Sugar > Glucids

Part of

@teolemon teolemon added the ✨ Feature Features or enhancements to Open Food Facts server label Jun 9, 2019
@stephanegigandet stephanegigandet changed the title On the fly quality checks On the fly quality checks in the product edit form (javascript) Jun 9, 2019
@teolemon teolemon added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Jun 9, 2019
@CharlesNepote
Copy link
Member

I think it's easy to add to my power user extension. Thus we can test it before launching it. I can code it with functions so that it will be easy to integrate in Product Opener later.

@VaiTon
Copy link
Member

VaiTon commented Jun 14, 2019

@CharlesNepote any news? Can I start working on this?

@CharlesNepote
Copy link
Member

@VaiTon adding too much controls/warnings can be risky: some people could stop without saving their work. It's the kind of work that we need to test in real conditions, during some weeks, before it gets ready for everyone.
So I would suggest two options:

Maybe, if it's possible, these controls could be shown after saving, on the confirmation screen.

@stephanegigandet
Copy link
Contributor

The checks proposed by @teolemon seem very good to me. We don't have to prevent users from saving (especially if it is something that they did not change, but are just editing a product with bad values), but we should at the very least display a warning.

@teolemon teolemon added the Perl Related to the Perl code of the ProductOpener server label Oct 10, 2019
@teolemon teolemon added the Fixable via Userscript This issue can be fixed using the Power User Script. label Jan 10, 2020
@stephanegigandet stephanegigandet added the Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org label Mar 25, 2020
@teolemon teolemon changed the title On the fly quality checks in the product edit form (javascript) Prevention - On the fly quality checks in the product edit form (javascript) Oct 11, 2021
@jnsereko
Copy link
Contributor

hey @yuktea @stephanegigandet
This looks interesting. Kindly assign it to me.
thanks

@yuktea
Copy link
Contributor

yuktea commented Mar 24, 2023

done, @jnsereko.

@jnsereko
Copy link
Contributor

created a PR #8258

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality ✨ Feature Features or enhancements to Open Food Facts server Fixable via Userscript This issue can be fixed using the Power User Script. Hacktoberfest help wanted JavaScript 🧽 on-the-fly quality checks Outreachy Good tasks for Outreachy applicants. See #productopener on our Slack https://slack.openfoodfacts.org Perl Related to the Perl code of the ProductOpener server
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants