fix: Dart uuid generation #1071
Conversation
There was a problem hiding this comment.
Good job @M123-dev!
Still some minor renaming to do: please have a look at my comments.
| import 'package:smooth_app/pages/user_preferences_dev_mode.dart'; | ||
| import 'package:uuid/uuid.dart'; | ||
|
|
||
| import 'local_database.dart'; |
There was a problem hiding this comment.
For consistency, please use a 'package:smooth_app/...' path.
| @@ -42,12 +45,22 @@ abstract class ProductQuery { | |||
|
|
|||
| /// Device Id, potentially used as API uuid. | |||
| static String? deviceId; | |||
There was a problem hiding this comment.
Please don't be afraid to remove deviceId. It's not a device id, and anyway it's the same as OFFConfig.uuid.
|
|
||
| /// Sets the device id as "final variable", for instance for API queries. | ||
| /// | ||
| /// To be called at main / init. | ||
| static Future<void> setDeviceId() async => OpenFoodAPIConfiguration.uuid = | ||
| deviceId = await PlatformDeviceId.getDeviceId; | ||
| static Future<void> setDeviceId(final LocalDatabase _localDatabase) async { |
There was a problem hiding this comment.
Please rename a setUuid.
|
Thanks for your review @monsieurtanuki, applied your comments |
| static const String UUID_NAME = 'UUID_NAME'; | ||
|
|
||
| /// Sets the device id as "final variable", for instance for API queries. | ||
| /// | ||
| /// To be called at main / init. | ||
| static Future<void> setDeviceId(final LocalDatabase _localDatabase) async { | ||
| static Future<void> setUuid(final LocalDatabase _localDatabase) async { |
There was a problem hiding this comment.
A file is missing, right? The one that called setDeviceId...
There was a problem hiding this comment.
Thank you @M123-dev: I have minor comments that will take you 5 seconds to fix.
Feel free to merge regardless if you are in a hurry.
| @@ -40,14 +42,21 @@ abstract class ProductQuery { | |||
| '_' | |||
| '${getCountry()!.iso2Code.toUpperCase()}'; | |||
|
|
|||
| /// Device Id, potentially used as API uuid. | |||
| static String? deviceId; | |||
| static const String UUID_NAME = 'UUID_NAME'; | |||
| @@ -40,14 +42,21 @@ abstract class ProductQuery { | |||
| '_' | |||
| '${getCountry()!.iso2Code.toUpperCase()}'; | |||
|
|
|||
| /// Device Id, potentially used as API uuid. | |||
| static String? deviceId; | |||
| static const String UUID_NAME = 'UUID_NAME'; | |||
|
|
|||
| /// Sets the device id as "final variable", for instance for API queries. | |||
There was a problem hiding this comment.
not "device id" but "uuid"
|
Applied both |
Now generation a random uuid and storing it instead of grabbing a local identifyer