fix: Null error when picking no picture #1124
Conversation
There was a problem hiding this comment.
Hi @M123-dev!
Perhaps your code fixes the issue, but I believe the flaw is upstream.
I don't believe in FutureBuilders. What about using LoadingDialog?
- I'm on a page
- I click on a button that runs async code
- which opens a "running" dialog with "close" button
- and when the code is over, the dialog is automatically closed
- and only then you go to your
ImageCropPagewith an already fully loaded image
Feel free to ignore my comment if you want your fix to be merged quickly.
| @@ -26,6 +26,14 @@ class ImageCropPage extends StatelessWidget { | |||
| return pickedXFile.readAsBytes(); | |||
| } | |||
|
|
|||
| // We need this callback to stop flutter from complaining that we pop while | |||
| // returning a placeholder container | |||
| void popCallback(Function() callback) { | |||
There was a problem hiding this comment.
Should at least be private.
github-actions
bot
added
🌐 l10n
Product addition
There was a problem hiding this comment.
Hi @M123-dev!
Looks much clearer without the FutureBuilder, doesn't it?
Please read my comment, as maybe you've added a superfluous dialog.
| final Uint8List? bytes = await LoadingDialog.run<Uint8List?>( | ||
| context: context, | ||
| future: pickImage(), | ||
| title: appLocalizations.selecting_photo, | ||
| ); |
There was a problem hiding this comment.
I'm not sure I would use a LoadingDialog here as the user has control over what's going on: picking an image. Just calling await picImage(); instead?
But maybe there's something I miss about UX: I never use that part of the app, as I cannot scan.
What
Fixes bug(s)