feat: #1060 - new dev mode lenient/strong matching switch #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"lenient" means @jasmeet0817's version, "strong" means @monsieurtanuki's. Why? Because for @jasmeet0817 it's impossible to be an "unknown" match. For @monsieurtanuki with at least one unknown attribute, you're at best "unknown". New file: * `smooth_matched_product.dart`: replacing off-dart's "MatchedProduct" Impacted files: * `personalized_ranking_page.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `product_compatibility_helper.dart`: not using off's `matched_product.dart` anymore * `smooth_it_model.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `smooth_product_card_found.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `summary_card.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `user_preferences_dev_mode.dart`: added a "lenient/strong" matching switch (aka "Swiss switch")
"lenient" means @jasmeet0817's version, "strong" means @monsieurtanuki's. Why? Because for @jasmeet0817 it's impossible to be an "unknown" match. For @monsieurtanuki with at least one unknown attribute, you're at best "unknown". New file: * `smooth_matched_product.dart`: replacing off-dart's "MatchedProduct" Impacted files: * `personalized_ranking_page.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `product_compatibility_helper.dart`: not using off's `matched_product.dart` anymore * `smooth_it_model.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `smooth_product_card_found.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `summary_card.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `user_preferences_dev_mode.dart`: added a "lenient/strong" matching switch (aka "Swiss switch")
"lenient" means @jasmeet0817's version, "strong" means @monsieurtanuki's. Why? Because for @jasmeet0817 it's impossible to be an "unknown" match. For @monsieurtanuki with at least one unknown attribute, you're at best "unknown". New file: * `smooth_matched_product.dart`: replacing off-dart's "MatchedProduct" Impacted files: * `personalized_ranking_page.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `product_compatibility_helper.dart`: not using off's `matched_product.dart` anymore * `smooth_it_model.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `smooth_product_card_found.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `summary_card.dart`: added the `UserPreferences` parameter for dev mode lenient/strong matching switch; not using off's `matched_product.dart` anymore * `user_preferences_dev_mode.dart`: added a "lenient/strong" matching switch (aka "Swiss switch")
|
I've finally managed to create a proper PR. |
M123-dev
approved these changes
Feb 13, 2022
| PreferenceImportance.ID_NOT_IMPORTANT: 0, | ||
| }; | ||
|
|
||
| /// Lenient version (monsieurtanuki) (found back in #1046) |
|
Thank you @M123-dev for your code review! I've changed the comment you mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"lenient" means @jasmeet0817's version, "strong" means @monsieurtanuki's.
Why? Because for @jasmeet0817 it's impossible to be an "unknown" match.
For @monsieurtanuki with at least one unknown attribute, you're at best "unknown".
New file:
smooth_matched_product.dart: replacing off-dart's "MatchedProduct"Impacted files:
personalized_ranking_page.dart: added theUserPreferencesparameter for dev mode lenient/strong matching switch; not using off'smatched_product.dartanymoreproduct_compatibility_helper.dart: not using off'smatched_product.dartanymoresmooth_it_model.dart: added theUserPreferencesparameter for dev mode lenient/strong matching switch; not using off'smatched_product.dartanymoresmooth_product_card_found.dart: added theUserPreferencesparameter for dev mode lenient/strong matching switch; not using off'smatched_product.dartanymoresummary_card.dart: added theUserPreferencesparameter for dev mode lenient/strong matching switch; not using off'smatched_product.dartanymoreuser_preferences_dev_mode.dart: added a "lenient/strong" matching switch (aka "Swiss switch")