feat: #1177 - new camera image getter with cropping feature #1184
Conversation
New files: * `abstract_camera_image_getter.dart`: Abstract getter of Camera Image, for barcode scan. * `camera_image_cropper.dart`: Camera Image Cropper, in order to limit the barcode scan computations. * `camera_image_full_getter.dart`: Camera Image helper where we get the full image. Impacted file: * `ml_kit_scan_page.dart`: now using new `CameraImageFullGetter` class - same full screen camera image capture as before for the moment.
teolemon
added
the
🤳🥫 Scan
Impacted files: * `ml_kit_scan_page.dart`: added optional scan / no scan options according to dev mode * `user_preferences.dart`: added methods for dev mode int values * `user_preferences_dev_mode.dart`: added a "scan mode" option on dev mode
|
@M123-dev ping |
There was a problem hiding this comment.
Looks good, thanks @monsieurtanuki
I can't say if there is a problem in the calculation part but it looks about right, now we have to test
| ); | ||
| } | ||
|
|
||
| @protected |
There was a problem hiding this comment.
https://api.flutter.dev/flutter/meta/protected-constant.html
Used to annotate an instance member in a class or mixin which is meant to be visible only within the declaring library, and to other instance members of the class or mixin, and their subtypes.
Looks to me like it's only usefull for libraries on pub.dev not for something private, but I could be wrong
There was a problem hiding this comment.
If I read the link you've provided, I think you're right.
If I test, I see I'm right:
| @@ -39,6 +39,7 @@ class UserPreferencesDevMode extends AbstractUserPreferences { | |||
| static const String userPreferencesFlagLenientMatching = '__lenientMatching'; | |||
| static const String userPreferencesFlagAdditionalButton = | |||
| '__additionalButtonOnProductPage'; | |||
| static const String userPreferencesEnumScanMode = '__scanMode'; | |||
There was a problem hiding this comment.
Maybe to confuse with userPreferencesFlagUseMLKit
There was a problem hiding this comment.
Indeed the confusion is possible: we're talking about scan parameters in both cases.
But I don't see how I could make it less confusing, and anyway it's the dev mode: things are not supposed to stay here forever.
|
@M123-dev Thank you for your review! |
New files:
abstract_camera_image_getter.dart: Abstract getter of Camera Image, for barcode scan.camera_image_cropper.dart: Camera Image Cropper, in order to limit the barcode scan computations.camera_image_full_getter.dart: Camera Image helper where we get the full image.Impacted file:
ml_kit_scan_page.dart: now using newCameraImageFullGetterclass - same full screen camera image capture as before for the moment.What
Part of