Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flattened the color/dark mode settings #1195

Merged
merged 6 commits into from
Mar 11, 2022
Merged

Flattened the color/dark mode settings #1195

merged 6 commits into from
Mar 11, 2022

Conversation

sgayangi
Copy link
Contributor

What

  • Removed the shadow of the widgets for changing darkmode and color theme of the app in the user preferences screen

Screenshot

Screenshot_20220311-194225

Fixes bug(s)

Part of

@sgayangi sgayangi requested a review from a team as a code owner March 11, 2022 14:18
@teolemon
Copy link
Member

@sgayangi : the CHANGELOG is generated automatically, as long as your Pull Request is semantic

@sgayangi
Copy link
Contributor Author

@sgayangi : the CHANGELOG is generated automatically, as long as your Pull Request is semantic

I'm really sorry, I didn't know that. I reverted that change, I hope that will fix it.

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyy, thanks for the PR @sgayangi, the code looks good.

Just a note, we have some predefined spaces in design_constants.dart I'd be if we'd use them here as well so that we don't mix different values throughout the app

@M123-dev
Copy link
Member

Thanks for the change @sgayangi, everything looks good now 👍🏼

@M123-dev M123-dev merged commit 6c0cbb0 into openfoodfacts:develop Mar 11, 2022
@M123-dev M123-dev mentioned this pull request Mar 11, 2022
4 tasks
@sgayangi
Copy link
Contributor Author

Thank you for the feedback :) looking forward to contributing more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants