-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flattened the color/dark mode settings #1195
Conversation
@sgayangi : the CHANGELOG is generated automatically, as long as your Pull Request is semantic |
I'm really sorry, I didn't know that. I reverted that change, I hope that will fix it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heyy, thanks for the PR @sgayangi, the code looks good.
Just a note, we have some predefined spaces in design_constants.dart
I'd be if we'd use them here as well so that we don't mix different values throughout the app
Thanks for the change @sgayangi, everything looks good now 👍🏼 |
Thank you for the feedback :) looking forward to contributing more |
What
Screenshot
Fixes bug(s)
Part of
(please be as granular as possible)