Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #1160 - added a "delete account" option #1201

Merged
merged 1 commit into from
Mar 13, 2022
Merged

feat: #1160 - added a "delete account" option #1201

merged 1 commit into from
Mar 13, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • user_preferences_profile.dart: added a "delete account" option; had to refactor the UI

What

  • we just open a "please delete my account" mail with a new ListTile
  • I had to change the UI: it was not possible to see 3 large green buttons side by side. I'm open to suggestions.

Screenshot

Simulator Screen Shot - iPhone 8 Plus - 2022-03-12 at 16 24 32

Part of

@monsieurtanuki
feat: openfoodfacts#1160 - added a "delete account" option
a7f7b5f 
Impacted file:
* `user_preferences_profile.dart`: added a "delete account" option; had to refactor the UI
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner March 12, 2022 15:28
M123-dev
M123-dev approved these changes Mar 12, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the UI changes make sense. I'd say we could provide more information for the user but since this is just temporary this is fine

@monsieurtanuki monsieurtanuki merged commit 21d7cf5 into openfoodfacts:develop Mar 13, 2022
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev for your review!

@github-actions github-actions bot mentioned this pull request Mar 13, 2022
Closed
@monsieurtanuki monsieurtanuki mentioned this pull request Mar 13, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@monsieurtanuki @M123-dev