Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: user management propoeses re login #1228

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

M123-dev
Copy link
Member

What

  • We now use Provider for UserManagement state
  • Updated UserPreferencesPage to be in it's own Statefull Widget
  • Fix for 827 are 1. watching UserManagement state & 2. Showing a loading indicator

Fixes bug(s)

@M123-dev M123-dev added the 👥 User management Account login, signup, signout label Mar 16, 2022
@M123-dev M123-dev requested a review from a team as a code owner March 16, 2022 20:23
@M123-dev M123-dev requested a review from monsieurtanuki March 16, 2022 20:34
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M123-dev!
I have minor comments; feel free to ignore them.

packages/smooth_app/lib/main.dart Outdated Show resolved Hide resolved
@M123-dev
Copy link
Member Author

Thanks for your review @monsieurtanuki, applied your proposals

@M123-dev M123-dev merged commit f671955 into develop Mar 17, 2022
@M123-dev M123-dev deleted the fix-user-management-propoeses-re-login branch March 17, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥫 Product page 👥 User management Account login, signup, signout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User management proposes logged in users to log again
2 participants