Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure the loading of the product example during onboarding does not block the UI #1237

Closed
Tracked by #561
teolemon opened this issue Mar 17, 2022 · 7 comments
Closed
Tracked by #561
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… P2
Milestone

Comments

@teolemon
Copy link
Member

What

  • Ensure the loading of the product example during onboarding does not block the UI

Part of

@teolemon teolemon added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Mar 17, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon What are we supposed to display while the data is being downloaded and if it's taking too long? How long is "too long"?

@teolemon
Copy link
Member Author

  • I think we should try loading silently, and succeed or fail silently.
  • Notifying about success or failure here does not bring much to the table (and we have a few extra seconds thanks to the next screen)

@monsieurtanuki
Copy link
Contributor

@teolemon That would mean that if there's no (or poor) internet connection we display the default value, i.e. en_US version?

@teolemon teolemon added the P2 label Mar 31, 2022
@teolemon teolemon added this to the V 1 milestone Mar 31, 2022
@teolemon teolemon modified the milestones: V1, V1.1 Apr 11, 2022
@atharv028
Copy link

atharv028 commented Apr 5, 2023

Please assign me this issue, if this is open. I would like to work on it

@M123-dev
Copy link
Member

M123-dev commented Apr 5, 2023

Sure @atharv028

@teolemon
Copy link
Member Author

teolemon commented Aug 3, 2023

@atharv028 I'm unassigning you. Feel free to reclaim if you're still working on it

@monsieurtanuki
Copy link
Contributor

Not relevant anymore as we already use a 5 second time-out, and in the big redesign we don't use the product example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… P2
Development

No branches or pull requests

4 participants