Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1308 - product list query now similar as barcode product query #1315

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • Podfile.lock: probably due to the pod refresh
  • product_list_page.dart: explicit fields, language and country (same as BarcodeProductQuery)

What

  • now we explicitly specify fields, language and country for the product list query (same as BarcodeProductQuery)
  • therefore we get the same results for both types of queries
  • as we did not have those explicit parameters, we did not have several important fields, which cause scores to disappear after a product list query refresh (they could not be computed due to lacking data)

Fixes bug(s)

…roduct query

Impacted files:
* `Podfile.lock`: probably due to the `pod` refresh
* `product_list_page.dart`: explicit `fields`, `language` and `country` (same as `BarcodeProductQuery`)
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner March 23, 2022 21:01
@monsieurtanuki monsieurtanuki requested a review from teolemon March 23, 2022 21:02
@monsieurtanuki monsieurtanuki merged commit 5a7eb16 into openfoodfacts:develop Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants