feat: Add links to the social media accounts of Open Food Facts #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g123k
requested changes
Mar 26, 2022
packages/smooth_app/lib/views/bottom_sheet_views/social_handle_view.dart
Outdated
Show resolved
Hide resolved
teolemon
reviewed
Mar 26, 2022
There was a problem hiding this comment.
- You mentioned you intended to solve Allow accessing the knowledge base from the app #1149 as part of this pr ?
- The URLs should be translatable. We have localized versions of all of this for some languages.
g123k
reviewed
Mar 26, 2022
packages/smooth_app/lib/views/bottom_sheet_views/social_handle_view.dart
Outdated
Show resolved
Hide resolved
Yes, earlier I was thinking to do it in this PR but then I thought of creating a separate PR for #1149. Mentioned in #915 :
Mentioned in #1149 : I've also added the words/terms in |
1 task
M123-dev
approved these changes
Mar 28, 2022
| ); | ||
| } | ||
|
|
||
| Widget buildContainer(BuildContext context) { |
There was a problem hiding this comment.
The name is a bit confusing also it could be private but let's just leave it as is for now
There was a problem hiding this comment.
I'll do resolve this in upcoming PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add links to the social media accounts of Open Food Facts
Screenshot
915.mp4
Fixes bug(s)
Part of
(please be as granular as possible)