New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistencies in the close button in settings #1340

Closed

teolemon opened this issue Mar 26, 2022 · 2 comments

Assignees

Labels

⚙️ Settings

Member

teolemon commented Mar 26, 2022 •

edited

Loading

What

Inconsistant placement of close button
Sometimes it does not look like a close button
Sometimes it's absent

Open questions

Should those be modals ?
Could they be converted to inline cards or bottom sheets ?

Part of

⚙️ Settings (tracker) #960

Screenshot/Mockup/Before-After

teolemon added the ⚙️ Settings label

Contributor

bhattabhi013 commented Mar 28, 2022

Hi @teolemon ,
Can I work on this?

bhattabhi013 mentioned this issue

fix: Inconsistencies in the close button in settings #1361

Merged

M123-dev assigned bhattabhi013

Contributor

bhattabhi013 commented Mar 28, 2022

Hi ,
We can close this issue as this is fixed by #1361.

M123-dev closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment