Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improved the card Tapabilty onboarding with selection on details of it #1364

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

abhay1821
Copy link
Contributor

… the card is tapped

What

  • The PR includes the improvement in tappability onboarding and selectability on the details of the Products page

Screenshot

fg.mov

Fixes bug(s)

@abhay1821 abhay1821 requested a review from a team as a code owner March 28, 2022 12:37
@bhattabhi013
Copy link
Contributor

Hi @abhay1821 ,
You can edit the PR title.

@abhay1821 abhay1821 changed the title Improved the card Tapabilty onboarding with selection on details of it fix: Improved the card Tapabilty onboarding with selection on details of it Mar 28, 2022
@abhay1821
Copy link
Contributor Author

Hi, @teolemon I think It should be smooth now with the Tappability and Text selection. Do let me know If more changes are required regarding this.

@abhay1821
Copy link
Contributor Author

Hi, @bhattabhi013 Thank you for the suggestion

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @abhay1821

@M123-dev M123-dev merged commit 35e125c into openfoodfacts:develop Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text selection makes cards less tappable (at least on onboarding ?)
4 participants