Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Product Addition) The "uploading image" dialog should not block the user from moving to the next photo #1393

Closed
2 of 4 tasks
Tracked by #1379
teolemon opened this issue Mar 29, 2022 · 8 comments
Closed
2 of 4 tasks
Tracked by #1379
Assignees
Labels
✏️ Contribution Offline - Contribution Offline 🎯 P1 Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.

Comments

@teolemon
Copy link
Member

teolemon commented Mar 29, 2022

What

Part of

Screenshot

image

@teolemon teolemon added the Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. label Mar 29, 2022
@stephanegigandet
Copy link
Contributor

Instead of having a "Uploading photo" dialog, we could just go back to the previous page with all the buttons to add pictures. And then we can have the progress bar there.

@stephanegigandet
Copy link
Contributor

Can we also add some text on the buttons on the bottom of the crop screen? e.g. "Cancel", and "Crop and upload"?

That way we can get rid of the next screen "Retake" and "Confirm", I don't really see the need for it.

image

@bhattabhi013
Copy link
Contributor

I agree with @stephanegigandet on adding the text at the bottom of the crop screen.

@g123k
Copy link
Collaborator

g123k commented Apr 17, 2022

@teolemon Could you elaborate a bit more on "The sections should not move to the bottom and stay put", please?

@g123k
Copy link
Collaborator

g123k commented Apr 17, 2022

For the uploading percentage, is-it really necessary?
If we implement a background task, where this progress should be displayed?

@teolemon
Copy link
Member Author

teolemon commented Apr 17, 2022

Stay put: Currently the photos are put at the bottom of the list. It should be inline, in-between buttons
image

@teolemon
Copy link
Member Author

The uploading percentage is a plus, not a strong requirement, especially if we have a background task.

@teolemon
Copy link
Member Author

teolemon commented Sep 1, 2022

Fixed by @AshAman999

@teolemon teolemon closed this as completed Sep 1, 2022
Repository owner moved this from In Progress to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Sep 1, 2022
@M123-dev M123-dev reopened this Sep 8, 2022
@M123-dev M123-dev closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Contribution Offline - Contribution Offline 🎯 P1 Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Development

No branches or pull requests

6 participants