Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Login and logout UX #1401

Merged
merged 1 commit into from
Mar 29, 2022
Merged

fix: Login and logout UX #1401

merged 1 commit into from
Mar 29, 2022

Conversation

bhattabhi013
Copy link
Contributor

What

fixes the issue: login terminology is not consistent with signup. We should mention username or email, especially in the Red warning text (currently: "Please enter some text").

Screenshot

image

Fixes bug(s)

Part of

@bhattabhi013 bhattabhi013 requested a review from a team as a code owner March 29, 2022 16:00
@teolemon teolemon added the 👥 User management Account login, signup, signout label Mar 29, 2022
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bhattabhi013

@M123-dev M123-dev merged commit 93e3be6 into openfoodfacts:develop Mar 29, 2022
@VaiTon VaiTon mentioned this pull request Mar 30, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👥 User management Account login, signup, signout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants