Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misaligned InkWells on clickable items #1457

Closed
g123k opened this issue Apr 2, 2022 · 2 comments · Fixed by #1459
Closed

Misaligned InkWells on clickable items #1457

g123k opened this issue Apr 2, 2022 · 2 comments · Fixed by #1459
Assignees
@abhay1821
Labels
🥫 Product page 🎨 UI / UX

Comments

@g123k
Copy link
Collaborator

g123k commented Apr 2, 2022

What

On a product detail, long pressing a clickable item shows an InkWell.
However, the greyed background is not centered:
Screen Shot 2022-04-02 at 12 48 03

Steps to reproduce the behavior

  1. Open a product
  2. Long press on an additive
@g123k g123k changed the title Misaligned InkWell on clickable items Misaligned InkWells on clickable items Apr 2, 2022
@abhay1821
Copy link
Contributor

Hi @g123k
Could you please assign this to me? I would like to work on it.

@VaiTon
Copy link
Member

VaiTon commented Apr 2, 2022

Hi @g123k Could you please assign this to me? I would like to work on it.

Done!
@g123k

@abhay1821 abhay1821 mentioned this issue Apr 2, 2022
Merged
@teolemon teolemon linked a pull request Apr 2, 2022 that will close this issue
fix: Misaligned Inkwell Fixed #1459
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhay1821 abhay1821

Labels
🥫 Product page 🎨 UI / UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Misaligned Inkwell Fixed abhay1821/smooth-app-1
3 participants
@g123k @VaiTon @abhay1821