Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enabled Circular border around country Selector #1464

Merged
merged 6 commits into from
Apr 5, 2022

Conversation

abhay1821
Copy link
Contributor

What

  • This PR includes fix of shape changes after the selection of the country is made.

Screenshot

Before Light Mode After In Light Mode After In Dark Mode

Fixes bug(s)

@abhay1821 abhay1821 requested a review from a team as a code owner April 2, 2022 15:41
@codecov-commenter
Copy link

codecov-commenter commented Apr 2, 2022

Codecov Report

Merging #1464 (9b7c8a0) into develop (53fb69c) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #1464      +/-   ##
==========================================
- Coverage     9.13%   9.04%   -0.09%     
==========================================
  Files          158     158              
  Lines         6372    6432      +60     
==========================================
  Hits           582     582              
- Misses        5790    5850      +60     
Impacted Files Coverage Δ
.../smooth_app/lib/pages/onboarding/welcome_page.dart 3.12% <0.00%> (-0.33%) ⬇️
...smooth_app/lib/pages/user_preferences_profile.dart 9.52% <0.00%> (-0.90%) ⬇️
packages/smooth_app/lib/pages/scan/scan_page.dart 2.50% <0.00%> (-0.28%) ⬇️
...mooth_app/lib/pages/user_preferences_settings.dart 7.87% <0.00%> (-0.13%) ⬇️
...smooth_app/lib/pages/product/new_product_page.dart 0.73% <0.00%> (-0.02%) ⬇️
packages/smooth_app/lib/pages/image_crop_page.dart 0.00% <0.00%> (ø)
...ges/smooth_app/lib/generic_lib/loading_dialog.dart 0.00% <0.00%> (ø)
...ges/smooth_app/lib/pages/product/summary_card.dart 0.00% <0.00%> (ø)
.../smooth_app/lib/data_models/onboarding_loader.dart 0.00% <0.00%> (ø)
...smooth_app/lib/pages/scan/search_history_view.dart 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53fb69c...9b7c8a0. Read the comment docs.

@abhay1821
Copy link
Contributor Author

Hi @M123-dev,
Could Please review it.

@g123k g123k linked an issue Apr 2, 2022 that may be closed by this pull request
@g123k g123k added the 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… label Apr 2, 2022
@VaiTon VaiTon requested review from g123k and M123-dev April 4, 2022 21:43
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@M123-dev M123-dev merged commit 6520be7 into openfoodfacts:develop Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding: Country selector doesn't have the same shape
4 participants