Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: minor design fixes in nutrition_page_loaded.dart #1475

Merged
merged 4 commits into from
Apr 4, 2022
Merged

feat: minor design fixes in nutrition_page_loaded.dart #1475

merged 4 commits into from
Apr 4, 2022

Conversation

VaiTon
Copy link
Member

@VaiTon VaiTon commented Apr 3, 2022

What

  • feat: minor design fixes in nutrition_page_loaded.dart
  • feat: use appbar button actions in nutrition_page_loaded.dart

@VaiTon
feat: use appbar button actions in nutrition_page_loaded.dart
ed60aa7 
feat: minor design fixes in nutrition_page_loaded.dart
@VaiTon VaiTon requested a review from a team as a code owner April 3, 2022 14:08
@VaiTon VaiTon added 🎨 UI / UX Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. labels Apr 3, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2022 •
edited
Loading

Codecov Report

Merging #1475 (efe1511) into develop (7453743) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #1475      +/-   ##
==========================================
- Coverage     9.10%   9.07%   -0.04%     
==========================================
  Files          158     158              
  Lines         6391    6415      +24     
==========================================
  Hits           582     582              
- Misses        5809    5833      +24
Impacted Files Coverage Δ
...h_app/lib/pages/product/nutrition_page_loaded.dart 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7453743...efe1511. Read the comment docs.

@VaiTon VaiTon requested a review from M123-dev April 3, 2022 20:14
M123-dev
M123-dev approved these changes Apr 4, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @VaiTon

@M123-dev
Copy link
Member

M123-dev commented Apr 4, 2022

Fixed some conflicts @VaiTon

@M123-dev M123-dev merged commit ebc0672 into openfoodfacts:develop Apr 4, 2022
@github-actions github-actions bot mentioned this pull request Apr 4, 2022
Closed
@VaiTon VaiTon deleted the ux/nutrition_page branch April 4, 2022 21:33
@bhattabhi013 bhattabhi013 mentioned this pull request Apr 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🎨 UI / UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VaiTon @codecov-commenter @M123-dev