Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turn off the alert message on user cancel #1496

Merged
merged 11 commits into from
Apr 5, 2022
Merged

fix: turn off the alert message on user cancel #1496

merged 11 commits into from
Apr 5, 2022

Conversation

bhattabhi013
Copy link
Contributor

What

turn off the alert message on user cancel.

Video

user_CAncel.mp4

Fixes bug(s)

Part of

@bhattabhi013 bhattabhi013 requested a review from a team as a code owner April 4, 2022 18:42
@codecov-commenter
Copy link

codecov-commenter commented Apr 5, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@35457d3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             develop   #1496   +/-   ##
=========================================
  Coverage           ?   9.07%           
=========================================
  Files              ?     158           
  Lines              ?    6414           
  Branches           ?       0           
=========================================
  Hits               ?     582           
  Misses             ?    5832           
  Partials           ?       0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35457d3...705d3c1. Read the comment docs.

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @bhattabhi013

@M123-dev M123-dev merged commit a608b96 into openfoodfacts:develop Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn the cancelled by user into a snackbar, or better, don't show it at all
4 participants