Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: String too long in nutrition edit #1524

Merged
merged 1 commit into from
Apr 8, 2022
Merged

fix: String too long in nutrition edit #1524

merged 1 commit into from
Apr 8, 2022

Conversation

bhattabhi013
Copy link
Contributor

What

fixes long string issue in the nutrition edit page.

Screenshot

Before:

  1. Nutrition edit page

image

  1. Edit product page

image

After:

  1. Nutrition edit page

image

  1. Edit product page

image

Fixes bug(s)

Part of

@bhattabhi013 bhattabhi013 requested a review from a team as a code owner April 8, 2022 17:43
@codecov-commenter
Copy link

Codecov Report

Merging #1524 (52efd7f) into develop (4449a9f) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #1524      +/-   ##
==========================================
+ Coverage     8.90%   8.91%   +0.01%     
==========================================
  Files          161     161              
  Lines         6569    6572       +3     
==========================================
+ Hits           585     586       +1     
- Misses        5984    5986       +2     
Impacted Files Coverage Δ
...mooth_app/lib/pages/product/edit_product_page.dart 0.00% <0.00%> (ø)
...h_app/lib/pages/product/nutrition_page_loaded.dart 0.00% <0.00%> (ø)
...ges/smooth_app/lib/generic_lib/loading_dialog.dart 0.00% <0.00%> (ø)
...smooth_app/lib/pages/user_preferences_profile.dart 9.52% <0.00%> (ø)
...mooth_app/lib/pages/user_preferences_settings.dart 7.87% <0.00%> (ø)
...ib/pages/product/common/product_dialog_helper.dart 0.00% <0.00%> (ø)
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 34.21% <0.00%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4449a9f...52efd7f. Read the comment docs.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhattabhi013 Wonderful: I guess AutoSizeText will help us solve many problems!

@monsieurtanuki monsieurtanuki merged commit 04cf585 into openfoodfacts:develop Apr 8, 2022
@bhattabhi013
Copy link
Contributor Author

@bhattabhi013 Wonderful: I guess AutoSizeText will help us solve many problems!

I think that too, it's a great add-on to the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants