Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1521 - immediate removal of the dismissed query #1525

Merged
merged 1 commit into from
Apr 9, 2022
Merged

fix: #1521 - immediate removal of the dismissed query #1525

merged 1 commit into from
Apr 9, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • search_history_view.dart: immediately removing the dismissed query

What

  • there were logged exceptions when a query was dismissed from the search history
  • the problem was that the display refresh needed the query to be removed faster than the actual removal/refresh from database: the exception was about the "display of a dirty dismissible"
  • the solution was to refresh the data asap, using the field we load the database to

Fixes bug(s)

@monsieurtanuki
fix: openfoodfacts#1521 - immediate removal of the dismissed query
d772e0c 
Impacted file:
* `search_history_view.dart`: immediately removing the dismissed query
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner April 8, 2022 20:05
@monsieurtanuki monsieurtanuki mentioned this pull request Apr 8, 2022
Closed
M123-dev
M123-dev approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VaiTon VaiTon merged commit 7dc2185 into openfoodfacts:develop Apr 9, 2022
@github-actions github-actions bot mentioned this pull request Apr 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monsieurtanuki @M123-dev @VaiTon