Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should define rules for user passwords #1555

Open
g123k opened this issue Apr 11, 2022 · 3 comments
Open

We should define rules for user passwords #1555

g123k opened this issue Apr 11, 2022 · 3 comments
Labels
security 👥 User management Account login, signup, signout

Comments

@g123k
Copy link
Collaborator

g123k commented Apr 11, 2022

While fixing #1542, @M123-dev raised an excellent question about passwords and spaces characters. Should we allow them? Before/After/Between…

Currently, the only rule we have is based on the length (>= 6 characters)

@bhattabhi013
Copy link
Contributor

Hi @g123k,
According to me, we can have 2 solutions here,

  1. We shouldn't trim the password input text field and allow users to input space characters.
  2. While validating the password text field, warn users about the space characters with a message like "blank space characters not allowed."
    I will love to hear other approaches too.

@AshAman999
Copy link
Member

@bhattabhi013 2nd one seems to be a good approach to me here

@abhay1821
Copy link
Contributor

Hi @g123k,
So When I worked on the trim issue,

  1. I Left the password field as It is since I checked google Facebook, and many other Sign Up pages. We can use space
    without any warning since there can be users who want to use spaces in their passwords.

  2. Moreover we too also have a show password option too where we can crosscheck if space is entered accidentally

So, In my opinion, it's not that big an issue to be resolved and spaces should be allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security 👥 User management Account login, signup, signout
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

4 participants