Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What should we do if the camera permission is denied? #1564

Closed
g123k opened this issue Apr 12, 2022 · 9 comments · Fixed by #1583
Closed

What should we do if the camera permission is denied? #1564

g123k opened this issue Apr 12, 2022 · 9 comments · Fixed by #1583
Assignees
Labels
permissions 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Milestone

Comments

@g123k
Copy link
Collaborator

g123k commented Apr 12, 2022

Everything is in the title: what should we do if the camera permission is denied?
Right now, the view (with the visor) is just black.

@monsieurtanuki
Copy link
Contributor

Suggestion:

  • instead of the black background and the visor
  • put a "authorize camera" button

@teolemon teolemon added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Apr 12, 2022
@teolemon teolemon added this to the V1 milestone Apr 12, 2022
@g123k
Copy link
Collaborator Author

g123k commented Apr 12, 2022

Something like that?
Artboard

@teolemon
Copy link
Member

I was thinking directly within the viewfinder, we don't know what the future holds for this card.

@g123k
Copy link
Collaborator Author

g123k commented Apr 12, 2022

A bit better, but not really a fan of it
Artboard

@monsieurtanuki
Copy link
Contributor

Thank you @g123k - the latest is more what I had in mind, but:

  • I would make it less intrusive (no blue "scan" icon)
  • I did not imagine the "hide" button, why not. But how do you put back the permission if you clicked on "hide" but it wasn't a good idea? Would we need another button to show it back again?

I imagined a unique "change permissions" button. Your text is good, just make it a button (no "hide", no "allow", no blue "scan" icon). The idea behind that is that:

  • we accept that the end-user don't authorize cameras
  • we (always) make it obvious that they probably should authorize cameras because scanning products is fun (?). That will let friends of the user ask "oh you can scan products, just accept the camera access"
  • anyway we have nothing less to do with that empty space where the scan/camera is supposed to be, and we're not going to heavily refactor the screen just for a probably minor part of the users, are we?

@M123-dev
Copy link
Member

FYK there are these unfinalized mocks

20220411_115104.jpg

@g123k
Copy link
Collaborator Author

g123k commented Apr 15, 2022

Thanks @M123-dev, will implement this

@g123k g123k self-assigned this Apr 15, 2022
@M123-dev
Copy link
Member

As said AFAIK they are just ideas so the button doesn't have to look like that. I also like your more AlertDialog style although the hide button probably doesn't make that much sense but I think we can all agree on the position of the button

@g123k
Copy link
Collaborator Author

g123k commented Apr 15, 2022

An initial implementation is available in #1583
Feel free to add some comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
permissions 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging a pull request may close this issue.

4 participants