Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixes new product found button overflow #1586

Merged
merged 4 commits into from
Apr 18, 2022
Merged

fix: fixes new product found button overflow #1586

merged 4 commits into from
Apr 18, 2022

Conversation

bhattabhi013
Copy link
Contributor

What

fixes new product found button overflow while scanning a new product.

Screenshot

image

Fixes bug(s)

Part of

@bhattabhi013 bhattabhi013 requested a review from a team as a code owner April 16, 2022 12:21
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2022

Codecov Report

Merging #1586 (42d34f2) into develop (7437093) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #1586      +/-   ##
==========================================
- Coverage     8.90%   8.84%   -0.07%     
==========================================
  Files          161     162       +1     
  Lines         6581    6694     +113     
==========================================
+ Hits           586     592       +6     
- Misses        5995    6102     +107     
Impacted Files Coverage Δ
...s/product_cards/smooth_product_card_not_found.dart 0.00% <0.00%> (ø)
...ric_lib/buttons/smooth_large_button_with_icon.dart 0.00% <0.00%> (ø)
packages/smooth_app/lib/main.dart 17.89% <0.00%> (-1.62%) ⬇️
...oth_app/lib/data_models/continuous_scan_model.dart 1.02% <0.00%> (-0.04%) ⬇️
...th_app/lib/pages/user_management/sign_up_page.dart 0.70% <0.00%> (-0.02%) ⬇️
...kages/smooth_app/lib/helpers/analytics_helper.dart 0.00% <0.00%> (ø)
...ges/smooth_app/lib/pages/product/summary_card.dart 0.00% <0.00%> (ø)
...s/smooth_app/lib/helpers/product_cards_helper.dart 0.00% <0.00%> (ø)
...s/smooth_app/lib/pages/onboarding/next_button.dart 4.00% <0.00%> (ø)
...smooth_app/lib/helpers/picture_capture_helper.dart 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7437093...42d34f2. Read the comment docs.

@g123k g123k linked an issue Apr 16, 2022 that may be closed by this pull request
@g123k
Copy link
Collaborator

g123k commented Apr 16, 2022

Thanks for your PR @bhattabhi013, but could you add some spaces between the three Widgets please?

@bhattabhi013
Copy link
Contributor Author

Thanks for your PR @bhattabhi013, but could you add some spaces between the three Widgets please?

Hi @g123k,
Spacer widget is already used between the three Widgets which defaults to a flex of one. If you want, I can use a SizedBox or increase the size of flex in the Spacer widget.

@teolemon teolemon modified the milestones: Sprint 1, V1 Apr 16, 2022
@bhattabhi013 bhattabhi013 requested a review from g123k April 16, 2022 15:00
@g123k
Copy link
Collaborator

g123k commented Apr 17, 2022

@bhattabhi013 I'm talking about the layout of the button, but the "external" Column.

@M123-dev M123-dev requested a review from g123k April 18, 2022 17:21
@g123k
Copy link
Collaborator

g123k commented Apr 18, 2022

Perfect, thanks for your work @bhattabhi013!

@g123k g123k merged commit 093dbac into openfoodfacts:develop Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scan card: "new product found" button overflow
4 participants