-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Uploading dialog with a message based on the photo type #1592
Conversation
…based on the type
Codecov Report
@@ Coverage Diff @@
## develop #1592 +/- ##
==========================================
- Coverage 8.86% 8.84% -0.03%
==========================================
Files 161 161
Lines 6623 6640 +17
==========================================
Hits 587 587
- Misses 6036 6053 +17
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @g123k!
I'm not an expert in translations, but I find it very risky to use a String parameter in that case.
I recommend something much safer:
"uploading_image_front": "Uploading front image to Open Food Facts",
"uploading_image_ingredients": "Uploading ingredients image to Open Food Facts",
"uploading_image_nutrition": "Uploading nutrition image to Open Food Facts",
"uploading_image_packaging": "Uploading packaging image to Open Food Facts",
"uploading_image_other": Uploading other image to Open Food Facts",
thank you @g123k 👍 |
#1591
Will display:
"Uploading front image to Open Food Facts"
"Uploading ingredients image to Open Food Facts"
"Uploading nutrition image to Open Food Facts"
"Uploading packaging image to Open Food Facts"
"Uploading other image to Open Food Facts"