Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Uploading dialog with a message based on the photo type #1592

Merged
merged 2 commits into from
Apr 17, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Apr 17, 2022

#1591

Will display:

"Uploading front image to Open Food Facts"
"Uploading ingredients image to Open Food Facts"
"Uploading nutrition image to Open Food Facts"
"Uploading packaging image to Open Food Facts"
"Uploading other image to Open Food Facts"

@g123k g123k added translations Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. labels Apr 17, 2022
@g123k g123k requested a review from a team as a code owner April 17, 2022 11:30
@g123k g123k self-assigned this Apr 17, 2022
@github-actions github-actions bot added 🌐 l10n and removed Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. labels Apr 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2022

Codecov Report

Merging #1592 (b074523) into develop (2ea0da3) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #1592      +/-   ##
==========================================
- Coverage     8.86%   8.84%   -0.03%     
==========================================
  Files          161     161              
  Lines         6623    6640      +17     
==========================================
  Hits           587     587              
- Misses        6036    6053      +17     
Impacted Files Coverage Δ
...mooth_app/lib/generic_lib/widgets/smooth_card.dart 0.00% <ø> (ø)
...smooth_app/lib/helpers/picture_capture_helper.dart 0.00% <0.00%> (ø)
...oth_app/lib/pages/onboarding/country_selector.dart 0.00% <0.00%> (ø)
...ges/smooth_app/lib/pages/product/summary_card.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/pages/scan/ml_kit_scan_page.dart 0.96% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aad0f2a...b074523. Read the comment docs.

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @g123k!
I'm not an expert in translations, but I find it very risky to use a String parameter in that case.
I recommend something much safer:

"uploading_image_front": "Uploading front image to Open Food Facts",
"uploading_image_ingredients": "Uploading ingredients image to Open Food Facts",
"uploading_image_nutrition": "Uploading nutrition image to Open Food Facts",
"uploading_image_packaging": "Uploading packaging image to Open Food Facts",
"uploading_image_other": Uploading other image to Open Food Facts",

@teolemon teolemon merged commit ffec189 into develop Apr 17, 2022
@teolemon teolemon deleted the upload_type branch April 17, 2022 17:13
@teolemon
Copy link
Member

thank you @g123k 👍

@g123k g123k linked an issue Apr 17, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Specify what kind of image is being uploaded
5 participants