Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Nutrient search field added #1627

Merged
merged 4 commits into from
Apr 24, 2022

Conversation

AshAman999
Copy link
Member

What

  • added a search box to filter on the nutrients selection page

Screenshot

Record_2022-04-23-07-35-52_cc729dbb1ea2c751a543590b5da9708c.mp4

Fixes bug(s)

@AshAman999 AshAman999 requested a review from a team as a code owner April 23, 2022 02:14
@AshAman999 AshAman999 force-pushed the nutrient-search-field branch from b4bae8d to e6e14a9 Compare April 23, 2022 02:14
@AshAman999
Copy link
Member Author

Not sure about the deprecation warnings, didn't seem like it is cuz of the changes I made 🥲

@M123-dev
Copy link
Member

It has nothing to do with this PR, a fix is already proposed and about to be merged

@teolemon
Copy link
Member

@M123-dev @AshAman999 all tests are now passing.
looks great UI wise

@codecov-commenter
Copy link

Codecov Report

Merging #1627 (a3551f5) into develop (2ea0da3) will decrease coverage by 0.16%.
The diff coverage is 0.84%.

@@            Coverage Diff             @@
##           develop   #1627      +/-   ##
==========================================
- Coverage     8.86%   8.69%   -0.17%     
==========================================
  Files          161     164       +3     
  Lines         6623    6807     +184     
==========================================
+ Hits           587     592       +5     
- Misses        6036    6215     +179     
Impacted Files Coverage Δ
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...rds/knowledge_panels/knowledge_panels_builder.dart 2.17% <0.00%> (ø)
...s/product_cards/smooth_product_card_not_found.dart 0.00% <0.00%> (ø)
.../smooth_app/lib/data_models/onboarding_loader.dart 0.00% <ø> (ø)
...mooth_app/lib/data_models/product_query_model.dart 1.38% <ø> (ø)
...s/smooth_app/lib/data_models/user_preferences.dart 34.42% <ø> (+2.11%) ⬆️
...s/smooth_app/lib/database/dao_string_list_map.dart 0.00% <0.00%> (ø)
...ckages/smooth_app/lib/database/local_database.dart 0.00% <0.00%> (ø)
...s/smooth_app/lib/database/paged_product_query.dart 0.00% <0.00%> (ø)
...oth_app/lib/database/robotoff_questions_query.dart 0.00% <0.00%> (ø)
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61cc714...a3551f5. Read the comment docs.

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heyy @AshAman999, looks great 👍🏼

@M123-dev M123-dev merged commit b333d73 into openfoodfacts:develop Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Allow to search for a specific nutrient in the nutrition edit mode
4 participants