feat: #1377 - reextract ingredients

[cli1005]

What

It should be possible to extract ingredients without taking a new photo
More details : #1377 (comment)

Screenshot

simulator-screen-recording-iphone-13-2022-04-25-at-163838_xiv1Anxx.mp4

Fixes bug(s)

• It should be possible to extract ingredients without taking a new photo #1377

Part of

• Allow to extract and save ingredients #107

[codecov-commenter]

Codecov Report

Merging #1644 (b9b1efa) into develop (2ea0da3) will decrease coverage by 0.19%.
The diff coverage is 1.04%.

@@            Coverage Diff             @@
##           develop   #1644      +/-   ##
==========================================
- Coverage     8.86%   8.66%   -0.20%     
==========================================
  Files          161     164       +3     
  Lines         6623    6829     +206     
==========================================
+ Hits           587     592       +5     
- Misses        6036    6237     +201     

Impacted Files	Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart	0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart	0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart	0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart	0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart	0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart	0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart	0.00% <0.00%> (ø)
...s/product_cards/smooth_product_card_not_found.dart	0.00% <0.00%> (ø)
.../smooth_app/lib/data_models/onboarding_loader.dart	0.00% <ø> (ø)
...mooth_app/lib/data_models/product_query_model.dart	1.38% <ø> (ø)
... and 30 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3a02d1...b9b1efa. Read the comment docs.

[teolemon]

It looks great 👍 @cli1005
I would add a little space between the field and the text, and possible curve the top of the card (if possible, not a big deal)

[teolemon]

@g123k @M123-dev @monsieurtanuki does that look good to you ?

[monsieurtanuki]

@teolemon I've already commented this PR (or I have and have forgotten to click on the "submit review" button):

• some minor formatting comments
• not fan of "we call the server but there's no progress display or cancel button"
• not fan of "we don't care if the server call failed"

Beyond that, this is not an area of the app where I've spent a lot of time, therefore I don't fully understand the functional purpose - but that looks rather good.

[monsieurtanuki]

Same behavior if onSubmitField crashes or not? pop(true)?

[cli1005]

onSubmitField shows an error message to the user in a SnackBar in case of failure. I will remove the return value to prevent confusion

[cli1005]

It looks great 👍 @cli1005 I would add a little space between the field and the text, and possible curve the top of the card (if possible, not a big deal)

✅

[monsieurtanuki]

Thank you @cli1005, LGTM!