Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Product remove cross is too small #1693

Closed
M123-dev opened this issue Apr 29, 2022 · 3 comments · Fixed by #1718
Closed

Product remove cross is too small #1693

M123-dev opened this issue Apr 29, 2022 · 3 comments · Fixed by #1718
Assignees
@bhattabhi013
Labels
🐛 bug Something isn't working product scan carousel

Comments

@M123-dev
Copy link
Member

What

It's very likely to miss the cross. The icon cam stay the size but the tappable area should be bigger

Screenshot_20220429-071953.jpg
@monsieurtanuki
Copy link
Contributor

I think the minimal touch target size is 48x48, as read in Material Design and alerted by Golden screenshot generation.
We could make it a "design constant".

@teolemon teolemon added 🐛 bug Something isn't working product scan carousel labels Apr 29, 2022
@bhattabhi013
Copy link
Contributor

Hi,
Can I work on this?

@bhattabhi013 bhattabhi013 mentioned this issue Apr 29, 2022
Merged
@bhattabhi013
Copy link
Contributor

This issue can be closed now as it was fixed by #1718 .

@teolemon teolemon linked a pull request Apr 30, 2022 that will close this issue
fix: Product remove cross is too small #1718
Merged
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bhattabhi013 bhattabhi013

Labels
🐛 bug Something isn't working product scan carousel
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Product remove cross is too small
4 participants
@teolemon @monsieurtanuki @M123-dev @bhattabhi013