Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update image cropper to 2.0.0 #1672 #1695

Merged
merged 2 commits into from
Apr 29, 2022

Conversation

AshAman999
Copy link
Member

What

  • updated the image cropper to 2.0.0

Fixes bug(s)

Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AshAman999!
Just 2 minor comments.

@@ -1157,5 +1171,5 @@ packages:
source: hosted
version: "3.1.0"
sdks:
dart: ">=2.15.1 <3.0.0"
dart: ">=2.16.1 <3.0.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit strange as in pubspec.yaml we have sdk: ">=2.15.1 <3.0.0"

packages/smooth_app/lib/pages/image_crop_page.dart Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #1695 (23775e9) into develop (2ea0da3) will decrease coverage by 0.57%.
The diff coverage is 0.74%.

@@            Coverage Diff             @@
##           develop   #1695      +/-   ##
==========================================
- Coverage     8.86%   8.29%   -0.58%     
==========================================
  Files          161     165       +4     
  Lines         6623    7128     +505     
==========================================
+ Hits           587     591       +4     
- Misses        6036    6537     +501     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <ø> (ø)
...s/knowledge_panels/knowledge_panel_table_card.dart 0.00% <0.00%> (ø)
...pp/lib/cards/product_cards/product_title_card.dart 0.00% <0.00%> (ø)
...cards/product_cards/smooth_product_card_found.dart 0.00% <0.00%> (ø)
... and 47 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb89eb5...23775e9. Read the comment docs.

@teolemon
Copy link
Member

thanks @AshAman999 👍
merging

@teolemon teolemon merged commit bd10bbb into openfoodfacts:develop Apr 29, 2022
@teolemon teolemon linked an issue Apr 29, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Product cropping crashes the app
4 participants