Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Creating a product from barcode search #1752

Merged
merged 2 commits into from
May 6, 2022

Conversation

PrimaelQuemerais
Copy link
Member

What

  • Added navigation to add_new_product_page from missing barcode dialog.

Screenshot

Fixes bug(s)

@PrimaelQuemerais PrimaelQuemerais requested a review from a team as a code owner May 5, 2022 15:22
@codecov-commenter
Copy link

Codecov Report

Merging #1752 (6c4dc2a) into develop (2ea0da3) will decrease coverage by 0.50%.
The diff coverage is 0.60%.

@@            Coverage Diff             @@
##           develop   #1752      +/-   ##
==========================================
- Coverage     8.86%   8.35%   -0.51%     
==========================================
  Files          161     167       +6     
  Lines         6623    7238     +615     
==========================================
+ Hits           587     605      +18     
- Misses        6036    6633     +597     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_summary_card.dart 0.00% <ø> (ø)
...s/knowledge_panels/knowledge_panel_table_card.dart 0.00% <0.00%> (ø)
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e050800...6c4dc2a. Read the comment docs.

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teolemon
Copy link
Member

teolemon commented May 6, 2022

looks good, merging for the demo @PrimaelQuemerais (we do that in 10 min)

@teolemon teolemon merged commit e175ebb into openfoodfacts:develop May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants