Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 Scroll to list card after adding product to a list #1699 #1776

Conversation

Pualoo
Copy link
Contributor

@Pualoo Pualoo commented May 6, 2022

Closes: #1699

What

The product page should scroll to the list card just after adding a product to a list.

I have to use the WidgetsBinding.instance.addPostFrameCallback because it need to scroll after the build the List Card.

Screenshot

smoth_app_example_.1699.mp4

@Pualoo Pualoo requested a review from a team as a code owner May 6, 2022 18:21
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@teolemon teolemon added the lists label May 8, 2022
@teolemon teolemon added this to the V1 milestone May 8, 2022
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @Pualoo

@M123-dev M123-dev merged commit 81afcfc into openfoodfacts:develop May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

The product page should scroll to the list card just after adding a product to a list.
3 participants