Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Attribute indicator addition #1801

Merged
merged 2 commits into from
May 10, 2022

Conversation

AshAman999
Copy link
Member

What

  • Added indicators on cards to let it be visible that the cards can be tapped

Screenshot

Screenshot_1652149963
Screenshot_1652149980

Fixes bug(s)

Part of

@AshAman999 AshAman999 requested a review from a team as a code owner May 10, 2022 02:38
@codecov-commenter
Copy link

Codecov Report

Merging #1801 (7020287) into develop (2ea0da3) will decrease coverage by 0.90%.
The diff coverage is 2.60%.

@@            Coverage Diff             @@
##           develop   #1801      +/-   ##
==========================================
- Coverage     8.86%   7.95%   -0.91%     
==========================================
  Files          161     169       +8     
  Lines         6623    7563     +940     
==========================================
+ Hits           587     602      +15     
- Misses        6036    6961     +925     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/cards/data_cards/score_card.dart 4.54% <0.00%> (-0.22%) ⬇️
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...t_cards/knowledge_panels/knowledge_panel_page.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_summary_card.dart 0.00% <ø> (ø)
... and 76 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90e2837...7020287. Read the comment docs.

Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @AshAman999

@M123-dev M123-dev merged commit c51c39a into openfoodfacts:develop May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening knowledge panels + attributes is very hard
3 participants