Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flutter 3.0 fixes #1814

Merged
merged 10 commits into from
May 12, 2022
Merged

fix: Flutter 3.0 fixes #1814

merged 10 commits into from
May 12, 2022

Conversation

M123-dev
Copy link
Member

@M123-dev M123-dev commented May 11, 2022

What

  • Fixes for flutter 3.0

Edit:

I know there are some

//ignore: use_build_context_synchronously

and better placable

if(!mounted)

but I'm in favor of keeping them like that for now and fixing them in a follow up PR to not make this PR bigger then it has to be

@M123-dev M123-dev requested a review from a team as a code owner May 11, 2022 20:15
@github-actions github-actions bot added 🤳 MLKit 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels May 11, 2022
@M123-dev M123-dev marked this pull request as draft May 11, 2022 20:45
@M123-dev M123-dev marked this pull request as ready for review May 11, 2022 21:09
@github-actions github-actions bot added 📈 Analytics We use Sentry and Matomo, with an opt-in system Android database dependancies ✏️ Editing - Nutrition input Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page summary card 🧪 Tests 👥 User management Account login, signup, signout labels May 11, 2022
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @M123-dev!
I agree with most of your changes.
Just a bit surprised by the removal of mounted: I would have added TODOs, because I guess we can expect unexpected behaviors.

@codecov-commenter
Copy link

Codecov Report

Merging #1814 (44b7539) into develop (2ea0da3) will decrease coverage by 2.25%.
The diff coverage is 2.28%.

@@            Coverage Diff             @@
##           develop   #1814      +/-   ##
==========================================
- Coverage     8.86%   6.61%   -2.26%     
==========================================
  Files          161     172      +11     
  Lines         6623    7821    +1198     
==========================================
- Hits           587     517      -70     
- Misses        6036    7304    +1268     
Impacted Files Coverage Δ
...h_app/lib/cards/category_cards/abstract_cache.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/asset_cache_helper.dart 0.00% <0.00%> (ø)
...p/lib/cards/category_cards/raster_async_asset.dart 0.00% <0.00%> (ø)
...oth_app/lib/cards/category_cards/raster_cache.dart 0.00% <0.00%> (ø)
..._app/lib/cards/category_cards/svg_async_asset.dart 0.00% <0.00%> (ø)
...smooth_app/lib/cards/category_cards/svg_cache.dart 0.00% <0.00%> (ø)
...th_app/lib/cards/data_cards/image_upload_card.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/cards/data_cards/score_card.dart 4.54% <0.00%> (-0.22%) ⬇️
...t_cards/knowledge_panels/knowledge_panel_card.dart 0.00% <0.00%> (ø)
...knowledge_panels/knowledge_panel_element_card.dart 0.00% <0.00%> (ø)
... and 117 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e135c19...44b7539. Read the comment docs.

@teolemon
Copy link
Member

e: /opt/hostedtoolcache/flutter/.pub-cache/hosted/pub.dartlang.org/qr_code_scanner-0.7.0/android/src/main/kotlin/net/touchcapture/qr/flutterqr/QRView.kt: (23, 1): Class 'QRView' is not abstract and does not implement abstract member public abstract fun onRequestPermissionsResult(p0: Int, p1: Array<(out) String!>, p2: IntArray): Boolean defined in io.flutter.plugin.common.PluginRegistry.RequestPermissionsResultListener
e: /opt/hostedtoolcache/flutter/.pub-cache/hosted/pub.dartlang.org/qr_code_scanner-0.7.0/android/src/main/kotlin/net/touchcapture/qr/flutterqr/QRView.kt: (216, 26): Null can not be a value of a non-null type String
e: /opt/hostedtoolcache/flutter/.pub-cache/hosted/pub.dartlang.org/qr_code_scanner-0.7.0/android/src/main/kotlin/net/touchcapture/qr/flutterqr/QRView.kt: (247, 26): Null can not be a value of a non-null type String
e: /opt/hostedtoolcache/flutter/.pub-cache/hosted/pub.dartlang.org/qr_code_scanner-0.7.0/android/src/main/kotlin/net/touchcapture/qr/flutterqr/QRView.kt: (310, 5): 'onRequestPermissionsResult' overrides nothing
e: /opt/hostedtoolcache/flutter/.pub-cache/hosted/pub.dartlang.org/qr_code_scanner-0.7.0/android/src/main/kotlin/net/touchcapture/qr/flutterqr/QRViewFactory.kt: (10, 1): Class 'QRViewFactory' is not abstract and does not implement abstract base class member public abstract fun create(p0: Context?, p1: Int, p2: Any?): PlatformView defined in io.flutter.plugin.platform.PlatformViewFactory
e: /opt/hostedtoolcache/flutter/.pub-cache/hosted/pub.dartlang.org/qr_code_scanner-0.7.0/android/src/main/kotlin/net/touchcapture/qr/flutterqr/QRViewFactory.kt: (13, 5): 'create' overrides nothing

@M123-dev M123-dev merged commit c3b44ac into develop May 12, 2022
@M123-dev M123-dev deleted the flutter-3.0-fixes branch May 12, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📈 Analytics We use Sentry and Matomo, with an opt-in system Android database ✏️ Editing - Nutrition input GitHub 🤳 MLKit 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… 🖼️ Photos - Cropping Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… summary card 🧪 Tests 👥 User management Account login, signup, signout
Development

Successfully merging this pull request may close these issues.

4 participants