-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Flutter 3.0 fixes #1814
fix: Flutter 3.0 fixes #1814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @M123-dev!
I agree with most of your changes.
Just a bit surprised by the removal of mounted
: I would have added TODO
s, because I guess we can expect unexpected behaviors.
Codecov Report
@@ Coverage Diff @@
## develop #1814 +/- ##
==========================================
- Coverage 8.86% 6.61% -2.26%
==========================================
Files 161 172 +11
Lines 6623 7821 +1198
==========================================
- Hits 587 517 -70
- Misses 6036 7304 +1268
Continue to review full report at Codecov.
|
e: /opt/hostedtoolcache/flutter/.pub-cache/hosted/pub.dartlang.org/qr_code_scanner-0.7.0/android/src/main/kotlin/net/touchcapture/qr/flutterqr/QRView.kt: (23, 1): Class 'QRView' is not abstract and does not implement abstract member public abstract fun onRequestPermissionsResult(p0: Int, p1: Array<(out) String!>, p2: IntArray): Boolean defined in io.flutter.plugin.common.PluginRegistry.RequestPermissionsResultListener |
What
Edit:
I know there are some
//ignore: use_build_context_synchronously
and better placable
if(!mounted)
but I'm in favor of keeping them like that for now and fixing them in a follow up PR to not make this PR bigger then it has to be