Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pluralization issue in French #1932

Closed
teolemon opened this issue May 22, 2022 · 6 comments · Fixed by #2736
Closed

Pluralization issue in French #1932

teolemon opened this issue May 22, 2022 · 6 comments · Fixed by #2736
Assignees
@monsieurtanuki
Labels
🐛 bug Something isn't working good first issue Good for newcomers 🌐 l10n P2
Milestone
V1.1

Comments

@teolemon
Copy link
Member

teolemon commented May 22, 2022 •
edited
Loading

What

Part of

Screenshot/Mockup/Before-After

image
@teolemon teolemon added the 🐛 bug Something isn't working label May 22, 2022
@teolemon
Copy link
Member Author

@VaiTon could you have a look at this one ?

@teolemon teolemon moved this from To discuss and validate to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 24, 2022
@teolemon teolemon added this to the V1.1 milestone Jun 11, 2022
@teolemon teolemon added P2 good first issue Good for newcomers labels Jul 23, 2022
@teolemon
Copy link
Member Author

teolemon commented Aug 7, 2022

Still here on August 7th 2022

@teolemon
Copy link
Member Author

teolemon commented Aug 7, 2022

Screenshot_20220807-170509.png

@VaiTon
Copy link
Member

VaiTon commented Aug 7, 2022

@VaiTon could you have a look at this one ?

I don't think I'm the right person as I speak little to no french :(

@monsieurtanuki monsieurtanuki self-assigned this Aug 10, 2022
@monsieurtanuki
Copy link
Contributor

I'm about to remove that text altogether. We don't need it anymore.
Especially because I'm thinking about a new system without the "Download next 25 products" button, where the scroll triggers the next download.

@teolemon
Copy link
Member Author

Great. Continuous scrolling is really a superior experience 👍

@monsieurtanuki monsieurtanuki linked a pull request Aug 10, 2022 that will close this issue
fix: #2729 - product query page - simplified top messages and buttons #2736
Merged
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🐛 bug Something isn't working good first issue Good for newcomers 🌐 l10n P2
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1.1
Development

Successfully merging a pull request may close this issue.

fix: #2729 - product query page - simplified top messages and buttons monsieurtanuki/smooth-app
3 participants
@teolemon @monsieurtanuki @VaiTon