Add a way to see what needs to be done in editing

[teolemon]

What

• Add a way to see what needs to be done in editing
• Solution 1: We could either color the section green if they are complete
• Solution 2: we could add a list of things to do:
  • Extend the attributes system to add a section for contribution openfoodfacts-server#7608

Part of

• Contribute (Tracker) #503

Mockups

V1 Screenshot

[teolemon]

@stephanegigandet started a proposal based on this: https://docs.google.com/document/d/1gUM739Oj2v-5F5DA1dz5p6pLMmRuzDCMgt_i_6BuxQw/edit#heading=h.g7z1r18bfycr

[monsieurtanuki]

@teolemon @stephanegigandet I'm not sure I get the added-value of the "edit attributes", and it's probably redundant with under-exploited fields.

I believe that the first step would be to display what we already have, which is already a good UI/UX question:

• where/when/how should we display the product states?
• which "click action" should we link to each "incomplete" tag?

For the record this is what we already retrieve with ProductField.STATES_TAGS (here only the "completed" tags):

• 'en:checked'
• 'en:complete'
• 'en:nutrition-facts-completed'
• 'en:ingredients-completed'
• 'en:expiration-date-completed'
• 'en:packaging-code-completed'
• 'en:characteristics-completed'
• 'en:origins-completed'
• 'en:categories-completed'
• 'en:brands-completed'
• 'en:packaging-completed'
• 'en:quantity-completed'
• 'en:product-name-completed'
• 'en:photos-validated'
• 'en:packaging-photo-selected'
• 'en:nutrition-photo-selected'
• 'en:ingredients-photo-selected'
• 'en:front-photo-selected'
• 'en:photos-uploaded'

[monsieurtanuki]

Also probably redundant with ProductImprovement:

• ORIGINS_TO_BE_COMPLETED
• CATEGORIES_BUT_NO_NUTRISCORE
• ADD_NUTRITION_FACTS
• ADD_CATEGORY
• ADD_NUTRITION_FACTS_AND_CATEGORY
• OBSOLETE_NUTRITION_IMAGE

[stephanegigandet]

@monsieurtanuki The "edit attributes" bring the same benefits as "product attributes": instead of having the app do all the logic of how to display a field (or what needs to be edited), we move this logic server side, so that it can be reused in multiple places (e.g. the OFF app, but also the OFF website, and possibly other apps). This also allows us to make changes without needing users to install a new version of the app.

We are about to start a large discussion of what the vision for the app is in the months to come. I think having a more seamless integration of the mobile app and website would be a good thing, so that users can go back and forth between them.

[monsieurtanuki]

@stephanegigandet My point was to say that we currently don't have an obvious way in Smoothie to check all the missing attributes for a product, like in @teolemon's OP.

My suggestion was to start from Smoothie and the existing product data (states, product improvements), and add somewhere (only in dev mode?) a "to be completed" screen. Which, when implemented with trial and error steps, will give us a better understanding of what we really need (e.g. new product fields) in practical cases.

That said, you definitely have a broader understanding of OFF.