Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic button that solves everything in the database #2395

Open
monsieurtanuki opened this issue Jun 27, 2022 · 2 comments
Open

Magic button that solves everything in the database #2395

monsieurtanuki opened this issue Jun 27, 2022 · 2 comments

Comments

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Jun 27, 2022

Problem

As evoked in #2255, there are at least two sentry issues related to probable database inconsistencies (like a product list whose products are not in the product database):

A typical log would display something like unexpected: unknown product for 3760091725769

Proposed solution

At app startup, we could run a database check and - if needed - solve the database inconsistencies (which means product downloads). We would display a "Oops" dialog with a "fix now!" button.

Additional context

Based on the same idea, we could check the local freshness of the products and suggest a refresh.

Part of

@VaiTon
Copy link
Member

VaiTon commented Aug 4, 2022

I propose doing that in a background thread and if needed block the user with a "Updading database version..." dialog, so that it doesn't seem like the app db is sometimes a mess (although it can be)

@monsieurtanuki
Copy link
Contributor Author

@VaiTon Actually it's not that messy, it's just a minor inconsistency. And from #2673 it's dealt with automatically when a product is displayed in a list.
We'll see how often we have issues like that.

@teolemon teolemon added the Sentry label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

3 participants