Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List all dialogs where we want vertical buttons #2805

Closed
5 tasks done
g123k opened this issue Aug 18, 2022 · 8 comments
Closed
5 tasks done

List all dialogs where we want vertical buttons #2805

g123k opened this issue Aug 18, 2022 · 8 comments
Assignees
@g123k
Labels
dialogs layout 🎯 P1

Comments

@g123k
Copy link
Collaborator

g123k commented Aug 18, 2022 •
edited
Loading

What

Hi everyone,

Now that #2626 is merged, we have to list all the dialogs where we want vertical layout for the buttons.
So please comment this issue will the list, allowing to start the development.

List

  • Contributors
  • Add to list
  • Login required (to edit)
  • Edit product (Ignore my changes / Save my changes)
  • Permission request

Part of
@g123k g123k mentioned this issue Aug 18, 2022
Merged
@teolemon
Copy link
Member

teolemon commented Aug 23, 2022 •
edited
Loading

Screenshot by Gala on her phone:

@g123k
Copy link
Collaborator Author

g123k commented Aug 23, 2022 •
edited
Loading

@teolemon Contributors is already vertical. Am I wrong?

  • The same goes for sign-in

@teolemon
Copy link
Member

So it seems

@g123k g123k self-assigned this Aug 23, 2022
@teolemon
Copy link
Member

@g123k g123k mentioned this issue Aug 30, 2022
Merged
@teolemon
Copy link
Member

teolemon commented Sep 2, 2022 •
edited
Loading

@g123k g123k mentioned this issue Sep 2, 2022
Merged
@teolemon
Copy link
Member

teolemon commented Sep 3, 2022

A screenshot of the edit product one
image

@g123k g123k mentioned this issue Sep 3, 2022
Merged
@teolemon
Copy link
Member

teolemon commented Sep 3, 2022

@g123k
Copy link
Collaborator Author

g123k commented Oct 24, 2022

I think all dialogs have been fixed. I'm closing the issue.
Please reopen it, if necessary

@g123k g123k closed this as completed Oct 24, 2022
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g123k g123k

Labels
dialogs layout 🎯 P1
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@g123k @teolemon